Skip to content

Support Decimals.jl v0.5 #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support Decimals.jl v0.5 #307

wants to merge 2 commits into from

Conversation

alyst
Copy link

@alyst alyst commented Feb 26, 2025 •
edited
Loading

This is a version of PR #306 that, in addition to updating the Decimals.jl to 0.5, also fixes the decimals-related tests.
The details for the test fixes are in the 2nd commit message.

I think the remaining test failures (more allocs than expected and some error message inconsistencies) are not related to decimals.

Closes #306

Alexey Stukalov added 2 commits February 25, 2025 21:39
Project.toml: support Decimals 0.5
0813793
tests: fix Decimal usage
ad61408 
* Decimals.jl v0.5 drops decimal() function, replace it with
parse(Decimal, "...")
* workaround the difference between the printing precision of BigFloat
and the storage precision of Decimal.
@alyst alyst changed the title support Decimals.jl v0.5 Support Decimals.jl v0.5 Feb 26, 2025
@alyst
Copy link
Author

alyst commented Feb 26, 2025

@iamed2 / @quinnj Could either of you review this PR? And, if it looks good to you, release a new patch version?

A number of packages, e.g. Turing.jl or SymbolicUtils.jl indirectly depend on Decimals.jl
LibPQ.jl not supporting Decimals.jl 0.5 prevents (quite obscurely) these packages from updating to the recent versions.

@alyst
Copy link
Author

alyst commented Mar 13, 2025

bump

@alyst
Copy link
Author

alyst commented Apr 1, 2025

I am trying to find the reviewers for the PR :) @ararslan, maybe you can take a look? The PR should help keeping the deps of LibPQ.jl-using projects up-to-date.

@ararslan
Copy link
Contributor

ararslan commented Apr 1, 2025

Seems reasonable to me, though my knowledge of LibPQ and Decimals is pretty limited. I do not, however, have write access to this repository, so my review here doesn't actually mean anything. 😅

@iamed2
Copy link
Collaborator

iamed2 commented Apr 1, 2025

How do the modified tests run on Decimals 0.4.1? Was this behaviour always available?

@alyst
Copy link
Author

alyst commented Apr 1, 2025

@ararslan Thank you! 😊

@iamed2 You can take a look at this temporary branch, where I have reverted Decimals.jl to 0.4.1: alyst#2. It passes the modified decimals tests, still fails on the (unrelated) memalloc count tests.

@alyst
Copy link
Author

alyst commented Apr 19, 2025

@iamed2 So LibPQ.jl and its tests should still run fine on Decimals.jl 0.4. Anything else I should consider for this PR?

@alyst
Copy link
Author

alyst commented May 25, 2025

@iamed2 Can you or any of the maintainers decide on this PR? I keep alyst#2 PR for you to address your backward compatibility concerns, but I am getting charged for running github actions on that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alyst @ararslan @iamed2